[Q] Need some assistance with a broken edify script. topic
I've been working on a script that takes an OTA zip file, adds GApps and some other modifications (including those to the updater-script) and then zips the ROM back up so that I could provide an easy OTA solution for my home devices that won't take me 45 minutes waiting on them to finish flashing. (in total, the script is supposed to cut down my update time by cutting out the copy/paste).
That part of my script seems to work perfectly, however update-binary throws a syntax error on the automatically compiled updater-script. Can anyone tell me what I'm doing wrong based on the update script below? I've wracked my brain for hours trying to figure out what's wrong here and have played around with line endings in case that was the cause but nothing.
The above only has one modification to it since I was toying around trying to fix this. The line break before the Google Apps was something I was inserting for a delineation of where the scripts combine at. That said, both ZIPs unmodified flash correctly and I have removed the signature from the ZIP file before re-compressing with modifications as well. I've written an edify script by hand before, but hadn't had this problem then, only when programatically creating an updater-script am I running into this.
EDIT: Sorry about the weird code block if you saw this before my update, that's what I get from copy/pasting from PuTTY.
That part of my script seems to work perfectly, however update-binary throws a syntax error on the automatically compiled updater-script. Can anyone tell me what I'm doing wrong based on the update script below? I've wracked my brain for hours trying to figure out what's wrong here and have played around with line endings in case that was the cause but nothing.
Code:
assert(getprop("ro.product.device") == "x5" || getprop("ro.build.product") == "x5" || getprop("ro.product.device") == "ls740" || getprop("ro.build.product") == "ls740" || abort("This package is for device: x5,ls740; this device is " + getprop("ro.product.device") + "."););
ifelse(is_mounted("/system"), unmount("/system"));
package_extract_dir("install", "/tmp/install");
set_metadata_recursive("/tmp/install", "uid", 0, "gid", 0, "dmode", 0755, "fmode", 0644);
set_metadata_recursive("/tmp/install/bin", "uid", 0, "gid", 0, "dmode", 0755, "fmode", 0755);
mount("ext4", "EMMC", "/dev/block/platform/msm_sdcc.1/by-name/system", "/system", "");
run_program("/tmp/install/bin/backuptool.sh", "backup");
unmount("/system");
if is_mounted("/data") then
run_program("/tmp/install/bin/otasigcheck.sh") != "31744" || abort("Can't install this package on top of incompatible data. Please try another package or run a factory reset");
else
mount("f2fs", "EMMC", "/dev/block/platform/msm_sdcc.1/by-name/userdata", "/data", "");
run_program("/tmp/install/bin/otasigcheck.sh") != "31744" || abort("Can't install this package on top of incompatible data. Please try another package or run a factory reset");
unmount("/data");
endif;
show_progress(0.750000, 0);
ui_print("Patching system image unconditionally...");
block_image_update("/dev/block/platform/msm_sdcc.1/by-name/system", package_extract_file("system.transfer.list"), "system.new.dat", "system.patch.dat");
show_progress(0.020000, 10);
mount("ext4", "EMMC", "/dev/block/platform/msm_sdcc.1/by-name/system", "/system", "");
run_program("/tmp/install/bin/backuptool.sh", "restore");
unmount("/system");
show_progress(0.050000, 5);
package_extract_file("boot.img", "/dev/block/platform/msm_sdcc.1/by-name/boot");
show_progress(0.200000, 10);
ui_print("***********************************************");
ui_print(" Google Apps for Android 5.0");
ui_print("***********************************************");
ui_print("Installing files...");
run_program("/sbin/busybox", "mount", "/system");
show_progress(1, 15);
delete("/system/app/Provision.apk","/system/app/QuickSearchBox.apk","/system/app/priv-app/SetupWizard.apk","/system/app/priv-app/Velvet.apk","/system/app/Vending.apk","/system/app/BrowserProviderProxy.apk","/system/app/PartnerBookmarksProvider.apk");
package_extract_dir("system", "/system");
set_perm(0, 0, 0755, "/system/addon.d/70-gapps.sh");
package_extract_dir("optional", "/tmp");
package_extract_file("install-optional.sh", "/tmp/install-optional.sh");
set_perm(0, 0, 0777, "/tmp/install-optional.sh");
run_program("/tmp/install-optional.sh", "");
show_progress(1, 15);
ui_print("Cleaning up and setting metadata...");
set_metadata_recursive("/system/addon.d", "uid", 0, "gid", 0, "dmode", 0755, "fmode", 0755, "capabilities", 0x0, "selabel", "u:object_r:system_file:s0");
set_metadata_recursive("/system/app", "uid", 0, "gid", 0, "dmode", 0755, "fmode", 0644, "capabilities", 0x0, "selabel", "u:object_r:system_file:s0");
set_metadata_recursive("/system/priv-app", "uid", 0, "gid", 0, "dmode", 0755, "fmode", 0644, "capabilities", 0x0, "selabel", "u:object_r:system_file:s0");
set_metadata_recursive("/system/etc/permissions", "uid", 0, "gid", 0, "dmode", 0755, "fmode", 0755, "capabilities", 0x0, "selabel", "u:object_r:system_file:s0");
set_metadata_recursive("/system/etc/preferred-apps", "uid", 0, "gid", 0, "dmode", 0755, "fmode", 0755, "capabilities", 0x0, "selabel", "u:object_r:system_file:s0");
set_metadata("/system/etc/g.prop", "uid", 0, "gid", 0, "mode", 0755, "capabilities", 0x0, "selabel", "u:object_r:system_file:s0");
set_metadata_recursive("/system/framework", "uid", 0, "gid", 0, "dmode", 0755, "fmode", 0644, "capabilities", 0x0, "selabel", "u:object_r:system_file:s0");
set_metadata_recursive("/system/lib", "uid", 0, "gid", 0, "dmode", 0755, "fmode", 0644, "capabilities", 0x0, "selabel", "u:object_r:system_file:s0");
set_metadata_recursive("/system/usr/srec/en-US", "uid", 0, "gid", 0, "dmode", 0755, "fmode", 0644, "capabilities", 0x0, "selabel", "u:object_r:system_file:s0");
set_metadata_recursive("/system/vendor/pittpatt", "uid", 0, "gid", 0, "dmode", 0755, "fmode", 0644, "capabilities", 0x0, "selabel", "u:object_r:system_file:s0");
run_program("/sbin/busybox", "umount", "/system");
ui_print("Installation complete!");The above only has one modification to it since I was toying around trying to fix this. The line break before the Google Apps was something I was inserting for a delineation of where the scripts combine at. That said, both ZIPs unmodified flash correctly and I have removed the signature from the ZIP file before re-compressing with modifications as well. I've written an edify script by hand before, but hadn't had this problem then, only when programatically creating an updater-script am I running into this.
EDIT: Sorry about the weird code block if you saw this before my update, that's what I get from copy/pasting from PuTTY.
xda-developers
0 commentaires:
Enregistrer un commentaire